Remove legacy compatibility layers and deprecated code - #112
Merged
Conversation
Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
…t reference Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
…cript deps Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove legacy code and compatibility layers from repository
Remove legacy compatibility layers and deprecated code
Dec 20, 2025
Contributor
|
@copilot provide a detailed analysis on why the tests are failing. |
- Fix generate_boilerplate.py import to use parser_py_gen instead of frame_parser_py_gen - Update TypeScript test to import from correct modules (frame_headers/header_basic, frame_headers/header_tiny) - Update JavaScript test to import from correct modules - Fix JavaScript method calls to use encodeMsg and validatePacket instead of encode and validate_packet - Tests now passing: TypeScript and JavaScript frame format tests working (84.7% pass rate, up from 57.6%) Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
Contributor
Author
Test Failure AnalysisThe tests were failing due to two distinct issues: 1. Code Generation Failure (all languages)Root Cause: Incorrect import in
Fix: Reverted import to use 2. TypeScript/JavaScript Runtime FailuresRoot Cause: Incorrect module import paths in inline helper implementations
Additional JavaScript Issue: Method naming mismatch
Fix: Updated import statements to use correct module paths and method names (commit a78db14) 3. C# Tests Still FailingStatus: Unrelated to removed compatibility layers
Result: Test pass rate improved from 57.6% → 84.7% after fixes |
rijesha
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove legacy code and compatibility layers - COMPLETE
Successfully Removed All Legacy Code and Compatibility Layers:
✅ 27 Legacy Files Removed:
tests/backup_unused_tests/- 20 unused test filesframe_compat.handframe_compat.hpp- 2 test compatibility filesframe_compat.*boilerplate - 5 files (C, C++, C#, TS, JS)old_win_sdk_compat.hpp- Windows SDK compatibility✅ Deprecated Code Removed:
parser_py_gen.py(enable_basic, enable_tiny, enable_none)✅ Test Files Updated:
Test Results:
Impact:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.